Skip to content
fix-lint logo

Fix Lint Skill

fix-lint

Helps fix oxlint errors and warnings in the OneKey codebase. Use when running yarn lint and encountering warnings, cleaning up code before committing, or fixing spellcheck, unused variable, or other linting warnings.

SKILL.md

Full skill instructions

Fix Lint Skill

This skill helps fix oxlint warnings in the OneKey app-monorepo codebase.

IMPORTANT: This project uses oxlint (not ESLint). The active linting configuration is in .oxlintrc.json.

Usage

Use this skill when:

  • Running yarn lint and encountering warnings
  • Cleaning up code before committing
  • Fixing spellcheck, unused variable, or other ESLint warnings

Workflow

Step 1: Run Lint and Analyze Warnings

yarn lint:only 2>&1 | tail -100

Step 2: Categorize Warnings

Warnings typically fall into these categories:

CategoryRuleFix Strategy
Spellcheck@cspell/​spellcheckerAdd to skip list or fix typo
Unused vars@typescript-eslint/​no-unused-varsRemove import or prefix with _
Non-null assertion@typescript-eslint/​no-non-null-assertionAdd type guard or cast
Nested componentsreact/​no-unstable-nested-componentsExtract component
Import orderimport/​orderFix import ordering

Step 3: Fix Each Category

Spellcheck Warnings (@cspell/​spellchecker)
  1. Evaluate the word: Is it a legitimate technical term or a typo?

  2. For legitimate technical terms, add to skip list:

    # File: development/​spellCheckerSkipWords.txt
    # Add the word on a new line at the end of the file
    newTechnicalTerm
    
  3. For known typos that can't be fixed (e.g., in translation keys), add with a comment above:

    # Known typo - exsited -> existed (ETranslations.some_key)
    exsited
    
  4. Common legitimate terms to add:

    • Build tools: chunkhash, minimizer, rspack
    • Blockchain: lovelace, Kusama, workchain, feebump
    • UI: Virtualized, overscan, overscrolling
    • Crypto: nacl, Bech32, secp256k1
Unused Variable Warnings (@typescript-eslint/​no-unused-vars)
  1. Unused imports - Remove the import:

    // Before
    import { Used, Unused } from 'package';
    // After
    import { Used } from 'package';
    
  2. Unused function parameters - Prefix with underscore:

    // Before
    function foo(used: string, unused: number) { return used; }
    // After
    function foo(used: string, _unused: number) { return used; }
    
  3. Unused destructured variables - Prefix with underscore:

    // Before
    const { used, unused } = obj;
    // After
    const { used, unused: _unused } = obj;
    
  4. Unused assigned variables - Prefix with underscore:

    // Before
    const unused = getValue();
    // After
    const _unused = getValue();
    
Non-null Assertion Warnings (@typescript-eslint/​no-non-null-assertion)

Add type assertions or guards:

// Before
const value = obj.prop!.name;
// After
const value = (obj.prop as { name: string } | undefined)?.name;
Nested Component Warnings (react/​no-unstable-nested-components)

Extract the component outside the parent:

// Before
function Parent() {
  const NestedComponent = () => <div />;
  return <NestedComponent />;
}

// After
const ExtractedComponent = () => <div />;
function Parent() {
  return <ExtractedComponent />;
}

Step 4: Verify Fixes

yarn lint:only 2>&1 | tail -50

Common Patterns in This Codebase

Translation Key Typos

Translation enum keys (e.g., ETranslations.perp_invaild_tp_sl) cannot be easily renamed as they're managed externally. Add to skip list with a comment:

# Known typo in translation key - invaild -> invalid
invaild

Provider API Methods

Methods like openInMobileApp that throw NotImplemented() often have unused parameters:

public async openInMobileApp(
  _request: IJsBridgeMessagePayload,
  _params: ISignMessagePayload,
): Promise<void> {
  throw new NotImplemented();
}

Destructuring from Hooks

When destructuring from hooks but not using all values:

const { used, unused: _unused } = usePromiseResult(...);

Tips

  1. Run lint with increased memory for large codebases:

    yarn lint:only
    
  2. Check if word is in skip list before adding:

    grep -i "wordToCheck" development/​spellCheckerSkipWords.txt
    
  3. For bulk fixes, use Task agents to parallelize work across multiple files

  4. Verify no regressions after fixes:

    yarn tsc:only
    

Files Modified During Lint Fixes

  • development/​spellCheckerSkipWords.txt - Add technical terms and known typos (one word per line, use # for comments)
  • Various .ts and .tsx files - Fix unused variables and imports

More skills from majiayu000

xiaohongshu logo
majiayu000/claude-arsenal

xiaohongshu

xiaohongshu

286 148
View
agent-task-conductor logo
majiayu000/claude-skill-registry

agent-task-conductor

Conduct multi-agent task orchestration and workflow coordination.

663 1
View
conductor-setup logo
majiayu000/claude-skill-registry

conductor-setup

Initialize project with Conductor artifacts (product definition,

663 1
View
animation-designer logo
majiayu000/claude-skill-registry

animation-designer

Expert in web animations, transitions, and motion design using Framer Motion and CSS

663 1
View
diagramming logo
majiayu000/claude-skill-registry

diagramming

Creates Mermaid and ASCII diagrams for flowcharts, architecture, ERDs, state machines, mindmaps, and more. Use when user mentions diagram, flowchart, mermaid, ASCII diagram, text diagram, terminal diagram, visualize, C4, mindmap, architecture diagram, sequence diagram, ERD, or needs visual docume...

663 1
View
h3-pg logo
majiayu000/claude-skill-registry-data

h3-pg

PostgreSQL bindings for H3 hexagonal grid system. Use when working with H3 cells in Postgres, including spatial indexing, geometry/geography integration, and raster analysis.

23 1
View
conductor-development logo
majiayu000/claude-skill-registry

conductor-development

Context-Driven Development skill for projects using Conductor. Use this skill when you detect a `conductor/` directory in the project, when working on tasks defined in a `plan.md` file, or when the user asks about tracks, specs, or plans. Automatically applies TDD workflow, tracks task completion...

663 1
View
conductor-status logo
majiayu000/claude-skill-registry

conductor-status

Display project status, active tracks, and next actions

663 1
View
dockerization logo
majiayu000/claude-skill-registry

dockerization

Official Stakpak application containerization standard operating procedure, a step-by-step guidline to properly dockerize applications. This is a rule book curated by the Stakpak Team.

663 1
View

Popular AI tools

Kaiber logo
Video

Kaiber

Generate, edit, and beat-sync AI video with leading models in one workspace.

Paid
View
Vimcal logo
Productivity

Vimcal

The world's fastest calendar for remote work

Free
View

Transform Your Design with AI Designer by ImgCreator.ai

Freemium
View
Akool AI logo
Content & writing

Akool AI

Revolutionizing Video Production with AI-Powered Creativity

Paid
View

Extend an image past the frame and let AI fill the new aspect ratio.

Freemium
View
StarByFace logo
Security

StarByFace

Discover your celebrity doppelgänger with StarByFace!

Free
View
C

ChainClarity explains 700+ crypto whitepapers in plain English, with layered summaries, comparisons, research tools, alerts, and a $4.99 Pro plan.

Freemium
View
Opus Clip logo
Coding & apps

Opus Clip

Opus.ai: Revolutionize Your Web Experience

Free
View