Factory — staged code review

Factory — staged code review

Quick start (DX)

Role

Act as a principal-level reviewer for staged changes only: quality, architecture, security, performance, and fit with the project. Pick a specialist lens from staged paths (references/​specialist-lenses.md). Optionally load minimal project context (references/​project-context.md) so feedback is grounded, not generic.

Hard rules

1. Never run git commit, git merge, git rebase, or otherwise create or alter commits.
2. Never draft Conventional Commits; use factory-conventional-commit for short / long messages.
3. Scope: git diff --cached / git diff --staged only — not the full working tree unless the user explicitly overrides.
4. Always write the report to .code-review/ at the repository root (create the directory if needed).

Procedure

1. Git — Confirm repo; run git diff --cached --stat then full git diff --cached.
2. Empty index — If no output, say nothing staged and suggest git add / git add -p. Do not create an empty report.
3. Lens — From staged paths, note specialist lens(es) per references/​specialist-lenses.md.
4. Context (optional) — Read a small set of project files only if they clarify the diff (references/​project-context.md).
5. Review — Apply rubric references/​review-rubric.md; justify impact; avoid taste-only nits.
6. Report file — Create .code-review/ if missing. Filename: staged-review-{YYYYMMDD-HHMMSS}.md (use date from shell when available, else ISO-like timestamp). Populate using references/​report-template.md. Use an absolute path for the next step.
7. Open in editor — After the file is written, open it so the user can read it immediately:
   • Preferred: cursor "<absolute-path-to-report.md>" (Cursor CLI; install from Command Palette: “Shell Command: Install ‘cursor’ command” if missing).
   • macOS fallback: open -a Cursor "<absolute-path>" if cursor is not in PATH.
   • Linux fallback: xdg-open "<absolute-path>" only if appropriate for the user’s setup.
   • If every open attempt fails (CLI missing, sandbox), say so in the chat line and rely on the path.
8. Chat — Reply with one short line: path to the report, whether it was opened, and optional one-line verdict. Do not paste the full report in chat unless the user asks.

Report contract

• Path: .code-review/​staged-review-<timestamp>.md
• Content: Follow references/​report-template.md: decision (APPROVE | REQUEST_CHANGES | BLOCK), confidence, staged file list, findings by severity, architecture/​testing notes, quick wins.
• Language: English for the report body (matches Factory docs convention).

Checklist (self)

• Used --cached / --staged for stat and patch.
• Report written under .code-review/ with unique filename (absolute path known).
• Attempted to open the report via cursor or fallback; noted failure if not possible.
• Findings reference file (and line when possible) from the staged patch.
• Specialist lens and project context (if any) stated in the report.
• No git commit; no Conventional Commit text.

Gotchas

• Open in editor — Some environments block GUI or CLI; opening is best-effort, not a hard gate.
• Unstaged work is out of scope unless needed to read context for a hunk (say so in the report).
• Partial staging — review exactly what --cached shows.
• Renames / binaries — git diff --cached --summary; binary: note change, no line nits.
• Generated blobs — call out; do not nitpick generated content.

Progressive disclosure

• Default: this file + template + rubric.
• Deeper: references/​specialist-lenses.md, references/​project-context.md.

Related skills

• factory-conventional-commit — short / long commit messages after you are satisfied with the review.